Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update build workflows node & add jest maxWorkers #2470

Merged
merged 5 commits into from Mar 28, 2021
Merged

chore: update build workflows node & add jest maxWorkers #2470

merged 5 commits into from Mar 28, 2021

Conversation

visiky
Copy link
Member

@visiky visiky commented Mar 27, 2021

PR includes

  • fixed #0
  • add / modify test cases
  • documents, demos

Screenshot

Before After
❌ ✅

@visiky visiky force-pushed the fix-ci branch 3 times, most recently from e5136c1 to 2d42aff Compare March 27, 2021 11:31
@visiky
Copy link
Member Author

visiky commented Mar 27, 2021

词云图的单测 就是跑不过，你看下在你的分支 skip 掉还是尝试定位修复，又或者先用我的分支，后面再修复词云图的单测
@hustcc

@visiky visiky requested a review from hustcc March 27, 2021 11:59
@visiky visiky force-pushed the fix-ci branch 4 times, most recently from 809cbdb to 3528efe Compare March 27, 2021 16:16
@visiky
Copy link
Member Author

visiky commented Mar 28, 2021

词云图的单测 就是跑不过，你看下在你的分支 skip 掉还是尝试定位修复，又或者先用我的分支，后面再修复词云图的单测

@hustcc

词云图的单测加上了fontSize 目前也暂时可以了。其他都是看到了就加上了 destroy。有空先合并这个分支，单测覆盖率下降了

@visiky visiky merged commit c9d79f1 into master Mar 28, 2021
@visiky visiky deleted the fix-ci branch March 28, 2021 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hustcc hustcc Awaiting requested review from hustcc

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@visiky