Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bullet): 修复轴组件添加max时，子弹图scale呈现不正确问题 #2639

Merged
merged 2 commits into from Jun 16, 2021
Merged

fix(bullet): 修复轴组件添加max时，子弹图scale呈现不正确问题 #2639

merged 2 commits into from Jun 16, 2021

Conversation

Angelii
Copy link
Contributor

@Angelii Angelii commented Jun 15, 2021 •
edited

PR includes

Screenshot

Before After
❌ ✅

@coveralls
Copy link

coveralls commented Jun 15, 2021 •
edited

Pull Request Test Coverage Report for Build 942427331

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.08%) to 95.978%
Files with Coverage Reduction New Missed Lines %
src/plots/chord/adaptor.ts 1 93.94%
src/plots/funnel/adaptor.ts 1 98.48%
src/utils/geometry.ts 1 90.91%
src/utils/hierarchy/partition.ts 2 88.68%
Totals Coverage Status
Change from base Build 930578592: -0.08%
Covered Lines: 6020
Relevant Lines: 6117
💛 - Coveralls

visiky
visiky reviewed Jun 15, 2021
View reviewed changes
src/plots/bullet/adaptor.ts Outdated Show resolved Hide resolved
@hustcc hustcc requested a review from visiky June 15, 2021 09:02
@visiky visiky merged commit dd23da5 into antvis:master Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visiky visiky Awaiting requested review from visiky

Assignees
No one assigned
Labels
PR: merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] Bullet plot renders incorrectly when using the max option of the axis component
3 participants
@Angelii @coveralls @visiky