fix(label): 处理venn图label遮挡问题 #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 PR Preview 6eea55a has been successfully built and deployed to https://antvis-G2Plot-preview-pr-2861.surge.sh?type=diff&date=2021-09-24 🕐 Build time: 122.063s
🤖 By surge-preview |
visiky
reviewed
Sep 18, 2021
| } | ||
| row[PATH_FIELD] = path; |
There was a problem hiding this comment.
row path 直接这么改？确定没问题？circle-path和intersection-path是一样的？
There was a problem hiding this comment.
intersectionAreaPath内部做了判断处理，包括了circlePath方法：
| const { x, y } = labelCfg.data; | ||
| const { offsetX, offsetY } = labelCfg.customLabelInfo; | ||
| return { | ||
| content: labelCfg.content[index], |
There was a problem hiding this comment.
看起来只是复写了 getLabelPoint 方法，label 布局调整（自动隐藏或自动省略的布局会有吗）
|
ci 没过？检查下？ |
嗯嗯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes
Screenshot