Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛bug: render issue of neo4j schema #558

Closed
nylqd opened this issue Nov 21, 2023 · 5 comments · Fixed by #559
Closed

🐛bug: render issue of neo4j schema #558

nylqd opened this issue Nov 21, 2023 · 5 comments · Fixed by #559

Comments

@nylqd
Copy link
Contributor

nylqd commented Nov 21, 2023

current schema canvas do not have edges, maybe another data process problem?
image

expected as follow
image

@pomelo-nwu
Copy link
Member

@nylqd t seems to be an issue with the EngineServer component:https://github.com/antvis/G6VP/blob/master/packages/gi-assets-neo4j/src/services/Engine.tsx#L1

@pomelo-nwu
Copy link
Member

https://github.com/antvis/G6VP/blob/master/packages/gi-sdk/src/components/EngineServer/LoadGraph.tsx#L148
because I have switched to the pref/sdk-valtio branch for the upgrade of G6 5.0, which involves a lot of changes, I haven't switched to the master branch to investigate the issue for now. If possible, I would appreciate your help in resolving it.

@nylqd
Copy link
Contributor Author

nylqd commented Nov 21, 2023

master/packages/gi-sdk/src/components/EngineServer/LoadGraph.tsx#L148 because I have switched to the pref/sdk-valtio branch for the upgrade of G6 5.0, which involves a lot of changes, I haven't switched to the master branch to investigate the issue for now. If possible, I would appreciate your help in resolving it.

@pomelo-nwu it seems indeed have bug in getSchemaGraph, i will do some digging around.
image

@nylqd
Copy link
Contributor Author

nylqd commented Nov 21, 2023

image

Adjusting the ID retrieval sequence to include source and target node types sounds like a reasonable approach to address the issue stemming from the lack of sourceNodeType and targetNodeType in the Neo4j schema information during parsing.

image

An alternative solution is adding sourceNodeType and targetNodeType attributes during the parsing of Neo4j schema information seems like a promising approach to address the root cause of the rendering issue.
image

@pomelo-nwu I'd like some inputs from you to choose one solution over the other

@pomelo-nwu
Copy link
Member

@nylqd Considering that different graph database will use the same EngineServer component, I am more inclined towards the second solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants