chore: fix alerts on lgtm.com

antvis · May 14, 2020 · 21adc93 · 21adc93
1 parent f00e288
commit 21adc93
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 17 deletions.
diff --git a/packages/x6/src/common/events.ts b/packages/x6/src/common/events.ts
@@ -65,24 +65,14 @@ export class Events<EventArgs extends Events.EventArgs = any> {
   off(name: null, handler: null, context: any): this
   off<Name extends Events.EventNames<EventArgs>>(
     name: Name,
-    handler: Events.Handler<EventArgs[Name]>,
-    context: any,
-  ): this
-  off<Name extends Events.EventNames<EventArgs>>(
-    name: Name,
-    handler: Events.Handler<EventArgs[Name]>,
-  ): this
-  off<Name extends Events.EventNames<EventArgs>>(name: Name): this
-  off<Name extends Events.UnknownNames<EventArgs>>(
-    name: Name,
-    handler: Events.Handler<any>,
-    context: any,
+    handler?: Events.Handler<EventArgs[Name]>,
+    context?: any,
   ): this
   off<Name extends Events.UnknownNames<EventArgs>>(
     name: Name,
-    handler: Events.Handler<any>,
+    handler?: Events.Handler<any>,
+    context?: any,
   ): this
-  off<Name extends Events.UnknownNames<EventArgs>>(name: Name): this
   off(
     name?: string | null,
     handler?: Events.Handler<any> | null,

diff --git a/packages/x6/src/view/edge.ts b/packages/x6/src/view/edge.ts
@@ -973,7 +973,7 @@ export class EdgeView<
 
     let name: string | undefined
     let args: Connector.BaseOptions | undefined
-    let fn: Connector.Definition | null | undefined
+    let fn: Connector.Definition
 
     if (typeof def === 'function') {
       fn = def
@@ -985,10 +985,11 @@ export class EdgeView<
     }
 
     if (name) {
-      fn = Connector.registry.get(name)
-      if (typeof fn !== 'function') {
+      const method = Connector.registry.get(name)
+      if (typeof method !== 'function') {
         return Connector.registry.onNotFound(name)
       }
+      fn = method
     } else {
       fn = Connector.presets.normal
     }