fix: afterCreate hook can return nullable values

antvis · Dec 24, 2019 · b783246 · b783246
1 parent 2d705bc
commit b783246
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/packages/x6/src/graph/decorator.ts b/packages/x6/src/graph/decorator.ts
@@ -44,7 +44,10 @@ export function afterCreate(aopName?: string | null) {
       const aop = (this.options as any)[name]
       if (aop != null) {
         args.unshift(instance)
-        return util.apply(aop, this, args)
+        const restult = util.apply(aop, this, args)
+        if (restult != null) {
+          return restult
+        }
       }
 
       return instance

diff --git a/packages/x6/src/graph/hook.ts b/packages/x6/src/graph/hook.ts
@@ -370,15 +370,19 @@ export interface IHooks {
     this: Graph,
     newNode: Cell,
     options: Cell.CreateNodeOptions,
-  ) => Cell
+  ) => Cell | null | undefined | void
 
   onCreateEdge?: (
     this: Graph,
     newEdge: Cell,
     options: Cell.CreateEdgeOptions,
-  ) => Cell
+  ) => Cell | null | undefined | void
 
-  onCreateGroup?: (this: Graph, newGroup: Cell, cells: Cell[]) => Cell
+  onCreateGroup?: (
+    this: Graph,
+    newGroup: Cell,
+    cells: Cell[],
+  ) => Cell | null | undefined | void
 
   // #endregion
 }