Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: history add max stack size #3253

Merged
merged 6 commits into from
Feb 17, 2023

Conversation

struggleRoue
Copy link
Collaborator

Description

history增加最大栈

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [✅] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. PR: unreviewed PR does not have any reviews. feature feature labels Feb 17, 2023
@x6-bot x6-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 17, 2023
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #3253 (fccd534) into master (eb921f7) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3253      +/-   ##
==========================================
- Coverage   33.07%   33.02%   -0.05%     
==========================================
  Files         274      274              
  Lines       17894    17924      +30     
  Branches     3865     3869       +4     
==========================================
+ Hits         5918     5920       +2     
- Misses      11569    11595      +26     
- Partials      407      409       +2     
Flag Coverage Δ
x6 18.46% <ø> (-0.05%) ⬇️
x6-common 63.43% <ø> (-0.04%) ⬇️
x6-geometry 55.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/x6/src/renderer/queueJob.ts 20.00% <0.00%> (-1.80%) ⬇️
packages/x6-common/src/dom/text.ts 57.83% <0.00%> (-0.37%) ⬇️
packages/x6/src/model/model.ts 9.81% <0.00%> (-0.28%) ⬇️

@struggleRoue struggleRoue changed the title feat: history add max stack size [WIP]feat: history add max stack size Feb 17, 2023
@x6-bot x6-bot bot removed the PR: unreviewed PR does not have any reviews. label Feb 17, 2023
@struggleRoue struggleRoue changed the title [WIP]feat: history add max stack size feat: history add max stack size Feb 17, 2023
@x6-bot x6-bot bot added the PR: unreviewed PR does not have any reviews. label Feb 17, 2023
@NewByVector NewByVector merged commit fba5310 into antvis:master Feb 17, 2023
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: unreviewed PR does not have any reviews. labels Feb 17, 2023
@x6-bot
Copy link
Contributor

x6-bot bot commented Feb 17, 2023

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

@x6-bot x6-bot bot added the released PR has released label Feb 17, 2023
@struggleRoue struggleRoue deleted the feat/history-max-stack branch February 17, 2023 14:31
@x6-bot
Copy link
Contributor

x6-bot bot commented Feb 18, 2023

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

@x6-bot
Copy link
Contributor

x6-bot bot commented Feb 24, 2023

🎉 This PR is included in the following release 🎉

Thanks for being a part of the AntV community! 💪💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature PR: merged PR has merged. released PR has released size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants