Premstats: complete project #1
Conversation
|
| Secret | Commit | Filename | Detected At | |
|---|---|---|---|---|
| RapidAPI Key | 4d2d195 | src/utils/fetchFunctions.js | 09:34 February 10th, 2022 | View secret |
| RapidAPI Key | 045952e | src/utils/fetchFunctions.js | 09:37 February 10th, 2022 | View secret |
馃洜 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
GitGuardian is an automated secrets detection service.We help developers and security teams secure the modern software development process.
聽
Our GitHub checks need improvements? Share your feedbacks
|
鉁旓笍 Deploy Preview for premstats ready! 馃敤 Explore the source changes: d3251cc 馃攳 Inspect the deploy log: https://app.netlify.com/sites/premstats/deploys/6204f88350cf17000884df62 馃槑 Browse the preview: https://deploy-preview-1--premstats.netlify.app |
There was a problem hiding this comment.
Hi @anuarshaidenov ,
Good job so far!
HIGHLIGHTS!
- No linters errors.馃挴
- Descriptive Readme.md. 馃挴
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes 鈾伙笍
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| [Live Demo Link (Netlify)](https://premstats.netlify.app/) | ||
| [Live Demo Link (Heroku)](https://premstats.herokuapp.com/) | ||
|
|
There was a problem hiding this comment.
You made great efforts to make this project. However, there are a few issues that you need to fix.
- Adding a LiveDemo link is perfect but you also need to display your Presentation Video 馃帴 link in your Readme.MD file. Please kindly add the LiveDemo link as well 馃敆
- Another thing in your readme is
Acknowledgements. Please also add this and give appropriate credit to the designer of the project, ok 馃憤
There was a problem hiding this comment.
Hi @anuarshaidenov,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 馃帀
Cheers and Happy coding!馃憦馃憦馃憦
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
Hi reviewer!馃檪
Here are the technical details of the project in a nutshell:
Cheers and happy coding!馃帀