Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Technical Steering] Contribution Policy update for resolving comments on PR #722

Closed
rabiabdel opened this issue Nov 28, 2019 · 1 comment · Fixed by #724
Closed

[Technical Steering] Contribution Policy update for resolving comments on PR #722

rabiabdel opened this issue Nov 28, 2019 · 1 comment · Fixed by #724
Assignees
@rabiabdel
Labels
Archive Archive Item
Projects
Technical Steering

Comments

@rabiabdel
Copy link
Collaborator

Proposal that: Comments/sub-Conversations within a PR may only be marked Resolved by A) The originator of the sub-conversation, B) the relevant WSL or C) an automated timeout of some duration (suggest 48hrs), when there has been no additional comments after an update is posted to resolve the sub-thread. In other words, the person responding to a sub-conversation shall not mark it as Resolved.

Rationale: The person evaluating a response cannot be authoritative to evaluate their own response. [Interest Conflict]
@rabiabdel rabiabdel created this issue from a note in Technical Steering (To do) Nov 28, 2019
@rabiabdel rabiabdel self-assigned this Nov 28, 2019
@rabiabdel rabiabdel added this to the Snezka milestone Nov 28, 2019
@rabiabdel
Copy link
Collaborator Author

rabiabdel commented Nov 28, 2019 •
edited

Ad discussed and agreed on TSC call on during 27th Nov 2019.

@rabi-abdel rabi-abdel mentioned this issue Nov 28, 2019
Merged
Technical Steering automation moved this from To do to Done Dec 9, 2019
@rabiabdel rabiabdel added the Archive Archive Item label Feb 11, 2020
@project-bot project-bot bot moved this from Done to Archive in Technical Steering Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rabiabdel rabiabdel

Labels
Archive Archive Item
Projects
Technical Steering
  
Archive
Milestone
No milestone
1 participant
@rabiabdel