Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clientcide.setAssetLocation does not apply to the Waiter Class. Fix included #67

Open
appaulo14 opened this issue Jun 21, 2010 · 0 comments

Comments

@appaulo14
Copy link

Problem:
Using Clientcide.setAssetLocation() does not effect the baseHref option of the Waiter class, causing waiter.gif to be pulled from http://www.cnet.com/html/rb/assets/global/waiter/ regardless of what Clientcide.assetLocation is.

What steps will reproduce the problem?:
To reproduce the problem, create a new instance of Waiter without changing the 'baseHref' option and examine where the resulting waiter image's src points to with Firebug or similar.

What is the expected output? What do you see instead?
In the expected result, the src property of the waiter image should be inside wherever Clientcide.assetLocation is set to (the default is http://github.com/anutron/clientcide/raw/master/Assets ). Instead, the src property is inside http://www.cnet.com/html/rb/assets/global/waiter/ , which is hardcoded into the class' baseHref option. Here is a mooShell to demonstrate: http://mootools.net/shell/PxFaD/4/

Fix:
I fixed this by doing a simply Class.refactor of the 'baseHref' option of the Waiter Class. Mooshell: http://mootools.net/shell/M8ZnY/1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant