You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem:
Using Clientcide.setAssetLocation() does not effect the baseHref option of the Waiter class, causing waiter.gif to be pulled from http://www.cnet.com/html/rb/assets/global/waiter/ regardless of what Clientcide.assetLocation is.
What steps will reproduce the problem?:
To reproduce the problem, create a new instance of Waiter without changing the 'baseHref' option and examine where the resulting waiter image's src points to with Firebug or similar.
Problem:
Using Clientcide.setAssetLocation() does not effect the baseHref option of the Waiter class, causing waiter.gif to be pulled from http://www.cnet.com/html/rb/assets/global/waiter/ regardless of what Clientcide.assetLocation is.
What steps will reproduce the problem?:
To reproduce the problem, create a new instance of Waiter without changing the 'baseHref' option and examine where the resulting waiter image's src points to with Firebug or similar.
What is the expected output? What do you see instead?
In the expected result, the src property of the waiter image should be inside wherever Clientcide.assetLocation is set to (the default is http://github.com/anutron/clientcide/raw/master/Assets ). Instead, the src property is inside http://www.cnet.com/html/rb/assets/global/waiter/ , which is hardcoded into the class' baseHref option. Here is a mooShell to demonstrate: http://mootools.net/shell/PxFaD/4/
Fix:
I fixed this by doing a simply Class.refactor of the 'baseHref' option of the Waiter Class. Mooshell: http://mootools.net/shell/M8ZnY/1/
The text was updated successfully, but these errors were encountered: