Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to show "views, comments, likes" of listed videos #559

Closed
Mo1967 opened this issue Jan 19, 2024 · 7 comments · Fixed by #588
Closed

Setting to show "views, comments, likes" of listed videos #559

Mo1967 opened this issue Jan 19, 2024 · 7 comments · Fixed by #588
Labels
enhancement New feature or request

Comments

@Mo1967
Copy link

Mo1967 commented Jan 19, 2024

v7.0.3+beta.1
For cleaner look and more space in own playlists and watch later, I suggest a setting point selectable by the user with or without Show "views, comments, likes" of listed videos" , independent to current setting to show in video description.

Screenshots: as example in v7.0.3+beta.1 versus v7.0.2.2
https://imgur.com/a/8NP4Xa1
vs.
https://imgur.com/a/JUsdowx

@Mo1967 Mo1967 added the enhancement New feature or request label Jan 19, 2024
@MoojMidge
Copy link
Collaborator

Open to more feedback on this.

I'm not too keen to add more settings unless necessary and also not keen to make the extra info in the main label seperately optional because it doesn't take up any extra space, it simply uses what available space is already available.

Not sure there is much benefit in trying to preserve empty space that may or may not exist - half the list items in your screenshot are already completely filling all the available space, and the display can change quite significantly in different skins, or even different views.

More importantly, from a functuonal perspective, the additional info also changes depending on the sort order, and making it optional limits the usefulness of the other sort options.

What I was considering was seeing whether another sort order could be used, so the extra details on the right hand side, which do take up extra space, can be changed. If another one is available then I can make it mimic the older display.

@Mo1967
Copy link
Author

Mo1967 commented Jan 19, 2024

@MoojMidge
if that is possible, can you tell me the file and lines to pound out (#) the feature to show "views, comments, likes" in listed videos, only ?
Thanks for your great work!

@MoojMidge
Copy link
Collaborator

You can disable the additional info on the left hand side by commenting out this:

@Mo1967
Copy link
Author

Mo1967 commented Feb 9, 2024

@MoojMidge
which lines are in beta 3 ? Thank you

@MoojMidge
Copy link
Collaborator

You can search for the same line of code. The line number may change, but the actual content of the line is unlikely to change in the near future.

https://github.com/search?q=repo%3Aanxdpanic%2Fplugin.video.youtube%20video_item.set_code(label_stats)&type=code

@steph09
Copy link

steph09 commented Feb 12, 2024

I've made the change above & it's got rid of the views & likes count in the video title but Is there any way to also stop it displaying the date next to the video length?

@MoojMidge
Copy link
Collaborator

At this stage, no.

It is possible to change, but not as easy as just removing or commenting out a single line of code.

@MoojMidge MoojMidge linked a pull request Feb 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants