Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useNamedParameters): use operationName instead of operationId #953

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

Marcel-G
Copy link
Collaborator

@Marcel-G Marcel-G commented Oct 2, 2023

Status

READY

Description

This feature was using operationId to construct the PathParameters name. For consistency, it would be better to use operationName as it can be mapped to something by users.

Related PRs

List related PRs against other branches:

branch PR
other_pr_production link
other_pr_master link

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

Outline the steps to test or reproduce the PR here.

> git pull --prune
> git checkout <branch>
> grunt jasmine

@vercel
Copy link

vercel bot commented Oct 2, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @anymaniax on Vercel.

@anymaniax first needs to authorize it.

@anymaniax
Copy link
Owner

Hello @Marcel-G seems good but could be a breaking change in some cases no?

@Marcel-G
Copy link
Collaborator Author

Marcel-G commented Oct 19, 2023

Hello @Marcel-G seems good but could be a breaking change in some cases no?

Technically yes, since the path parameter types are public and would effect consumers who:

  • Are already using useNamedParameters and
  • Have operations named with operationId or custom naming override and
  • Are directly importing the Path parameters model type in their projects

@anymaniax
Copy link
Owner

@Marcel-G should be a really little number of ppl tho no?

@Marcel-G
Copy link
Collaborator Author

@Marcel-G should be a really little number of ppl tho no?

Yes very few I imagine

@anymaniax anymaniax merged commit 8a458ca into anymaniax:master Oct 19, 2023
2 of 3 checks passed
@anymaniax
Copy link
Owner

@Marcel-G I don't know if you are often on discord but if you could be discuss there with the other maintainers would be great

@Marcel-G Marcel-G deleted the fix/path-parameters-name branch October 19, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants