Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter #1

Closed
semisight opened this issue Apr 20, 2022 · 2 comments
Assignees

Comments

@semisight
Copy link

semisight commented Apr 20, 2022

https://github.com/anytrack/Google-Tag-Manager-Templates/blob/82fc8f864612ad49c231ac145e77dea8c4633e9d/template.tpl#L72

When reviewing your template we've noticed that it is using parameters to build a url. It's a best practice to use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter.

@shftlvch
Copy link
Member

@semisight 👋, fixed in the newest version. Thank you.

@ljmalka
Copy link
Member

ljmalka commented May 2, 2023

https://github.com/anytrack/Google-Tag-Manager-Templates/blob/82fc8f864612ad49c231ac145e77dea8c4633e9d/template.tpl#L72

When reviewing your template we've noticed that it is using parameters to build a url. It's a best practice to use EncodeUri() if part of the URL path or EncodeUriComponent() if used as a URL parameter.

Hi @semisight - Issue fixed.
Thank you for pointing out.
When will the template be public?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants