Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can wallet logo pics be somewhere central location that wont change? #74

Closed
nukec opened this issue Sep 14, 2021 · 3 comments
Closed

Can wallet logo pics be somewhere central location that wont change? #74

nukec opened this issue Sep 14, 2021 · 3 comments

Comments

@nukec
Copy link

nukec commented Sep 14, 2021

I guess a lot of websites were broken:
image
@jordaaash
Copy link
Collaborator

Just fixed. Yeah, I'll compile them into the wallets package and/or make sure they don't move. Sorry about that!

@jordaaash jordaaash reopened this Sep 14, 2021
@jordaaash
Copy link
Collaborator

I'll leave this open until it's done.

@jordaaash
Copy link
Collaborator

https://github.com/solana-labs/wallet-adapter/blob/master/packages/wallets/icons/__DO_NOT_MOVE__.txt

Wallet icon image files will remain at this location until at least version 1.0 is released.

However, all wallets have been converted to use base64 for embedding images, so this kind of thing won't happen for anyone who upgrades.

https://github.com/solana-labs/wallet-adapter/blob/a630fdb746e7d9f152bc507e49b1b7b62b556307/packages/core/wallets/src/wallets.ts#L88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordaaash @nukec