Python source code hard to read

[PyvesB]

Hello again! 👋

Python source code is very hard to read. See the following screenshot:

I'm guessing Pydev handles its own colour preferences. Obviously it's probably not manageable to handle every single third-party plugin, but in this case Pydev is the 5th most popular plugin on the markteplace, so may be worth adding support for it. 😉

[AObuchow]

Agreed I think PyDev and other common Eclipse plugins should be supported ideally :) I've added some CSS preferences for Pydev quickly - I don't even have it installed so I haven't tested how it looks yet.

@PyvesB could you please update to the latest build and share a screenshot of how the Python colors look? Also feel free to submit tweaks to them if you want :)

[PyvesB]

Hmm, this is what I get in a fresh workspace:

[AObuchow]

Thanks for the screenshot.
I referenced https://github.com/fabioz/Pydev/blob/cf765a4925da47f24043a8ac67cf186c7bce6cc6/plugins/org.python.pydev/css/dark/e4-pydev-dark_preferencestyle.css in the latest patch.

However, the blue color used for methods still seems unreadable. Please update and provide another screenshot to see how it looks now (I apologize I have yet to simply download PyDev..)

[PyvesB]

I'm under the impression that my installation is not updating properly. I pulled in the latest version of the plugin, but I don't seem to see any changes from this issue, #76 or #79. I've tried disabling Oomph and using a fresh workspace, to no avail. Unlike #63, I'm not able to find these properties in the .metadata folder.

[AObuchow]

No worries, I’ll try bumping the version to 1.0.8 and see if that helps :)

[PyvesB]

Digging further, there does seem to be a problem.

Installation Details -> Installed Software shows Modern Dark Theme 1.0.7.202006231446 com.aobuchow.themes.moderndark.feature.feature.group aobuchow

But Installation Details -> Plug-ins shows aobuchow Modern Dark Theme 1.0.7.202006221505 com.aobuchow.themes.moderndark

[AObuchow]

Ahh thank you for spotting that !!

I’m not sure if the issue is in the build or the CI or elsewhere. If you have the time, you could try cloning the repo’s master branch and do mvn verify and install from the local updatesite.

We can then determine if local builds are fine or if there’s an issue with them currently.

[PyvesB]

My gut feeling is that there's nothing wrong with this plugin. This same thing happened to me once in the past with WildWebDeveloper. I did revert my installation a couple of times between yesterday and this morning, I'm wondering whether this got things messed up. I'll try cleaning up my p2 caches and see if that helps before investigating whether there's anything wrong with this project.

[AObuchow]

No worries, let me know if you're able to resolve the issue!

[PyvesB]

For the record, I had to modify these two files in my Eclipse installation:
Eclipse/configuration/org.eclipse.update/platform.xml
Eclipse/configuration/org.eclipse.equinox.simpleconfigurator/bundles.info

They had ended up containing duplicate entries of Modern Dark theme with outdated version numbers.

[PyvesB]

Python source code is now fully readable!

[AObuchow]

@PyvesB thanks for the info, could be useful in the future.

Glad the python syntax coloring looks better now :) I'm going to close this issue for the time being.