Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 'attack speed' to 'attack interval' to avoid confusion #19

Merged
merged 1 commit into from Jul 12, 2022

Conversation

Taloth
Copy link
Member

@Taloth Taloth commented Jul 12, 2022

Tweaked names on 'attack speed' to 'attack interval' to deal with the confusing reversed terminology.
Coz "Attack speed decreased" sounds like a nerf, but it's a buff coz the time between attacks is decreased, so interval is decreased, speed increased. Every single patch note review somebody stumbles over it.

There's also a fix for a buff that was accidentally called a nerf. And Bonus damage now with appropriate + prefix.


Perhaps even rename 'ATTACK SPEED' to 'ATTACK INTERVAL' on the main explorer as well. But that's optional.

At mentioned before, there is confusing terminology about this throughout. Like "Attack speed bonus +20%", is also a buff, it increases the speed by 20%, thus reduces the interval in seconds. So for bonuses it's the reverse.
(I also don't know if it's New attack interval = Old attack interval * 0.8 or New attack rate = Old attack rate * 1.2, where attack rate = 1 / attack interval. It's probably the later, but who knows how it's actually coded.)

Even the 'reload time' implementation isn't consistent, see Reload Drills vs Crossbow Stirrups.

… confusing reversed terminology. And some other minor fixes.
@robertvanhoesel
Copy link
Member

Thanks for these. I'm wondering if long term 'Attack Duration' would make sense, or if that also would set false expectations (i.e. the initial charge maybe be earlier in the attack, then there's cooldown).

(I also don't know if it's New attack interval = Old attack interval * 0.8 or New attack rate = Old attack rate * 1.2, where attack rate = 1 / attack interval. It's probably the later, but who knows how it's actually coded.)
There's actually some more to it yeah, reload time != attack interval because it is only a part of the full animation cycle.

@robertvanhoesel robertvanhoesel merged commit dc1f4fa into aoe4world:main Jul 12, 2022
@Taloth
Copy link
Member Author

Taloth commented Jul 12, 2022

Attack Duration could be confused with attacks that do damage over time for example multiple nest of bee projectiles, things like that. So Interval = Attack Chargeup + Attack Duration + Attack Cooldown.
It doesn't matter much, it'd be better than Attack Speed.

There's actually some more to it yeah, reload time != attack interval because it is only a part of the full animation cycle.

Ah, yes, that explains it. I suspected something like that. Tnx for the confirmation.
It does make it harder for harder for players to figure out what certain upgrades actually mean, but that's always been the case in games like this.

@Taloth Taloth deleted the season-2-cleanup branch July 12, 2022 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants