Changed 'attack speed' to 'attack interval' to avoid confusion #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaked names on 'attack speed' to 'attack interval' to deal with the confusing reversed terminology.
Coz "Attack speed decreased" sounds like a nerf, but it's a buff coz the time between attacks is decreased, so interval is decreased, speed increased. Every single patch note review somebody stumbles over it.
There's also a fix for a buff that was accidentally called a nerf. And Bonus damage now with appropriate
+
prefix.Perhaps even rename 'ATTACK SPEED' to 'ATTACK INTERVAL' on the main explorer as well. But that's optional.
At mentioned before, there is confusing terminology about this throughout. Like "Attack speed bonus +20%", is also a buff, it increases the speed by 20%, thus reduces the interval in seconds. So for bonuses it's the reverse.
(I also don't know if it's
New attack interval = Old attack interval * 0.8
orNew attack rate = Old attack rate * 1.2
, whereattack rate = 1 / attack interval
. It's probably the later, but who knows how it's actually coded.)Even the 'reload time' implementation isn't consistent, see Reload Drills vs Crossbow Stirrups.