New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust TextGroup and SliverAppBarDelegate #6

Closed

Aoi-hosizora opened this issue Dec 28, 2020 · 1 comment

Labels

Owner

Aoi-hosizora commented Dec 28, 2020 •

edited

Loading

Here should be add(xxx) rather than insert(0, xxx).

flutter_ahlib/lib/src/widget/text_group.dart

Line 229 in c6bd720

children: spans..insert(0, TextSpan(text: ' ')), // insert an empty TextSpan.

Add these options (or others) for TextGroup.

flutter_ahlib/lib/src/widget/text_group.dart

Lines 268 to 269 in c6bd720

    
           // showCursor: widget.showCursor, 
        
           // autofocus: widget.autofocus,

Here should use assert rather than math.max:

flutter_ahlib/lib/src/widget/sliver_appbar_delegate.dart

Lines 36 to 37 in c6bd720

    
           }) : assert(minHeight != null), 
        
                assert(maxHeight != null),

The text was updated successfully, but these errors were encountered:

Aoi-hosizora added the enhancement label

Aoi-hosizora changed the title ~~Adjust TextGroup~~ Adjust TextGroup and SliverAppBarDelegate

Owner Author

Aoi-hosizora commented Dec 30, 2020

Done

Aoi-hosizora closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment