New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add editorconfig for code style consistency. Format gradle files base… #381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 space indention - is this only for the gradle files or are we going to use the same for java files as well?
@@ -1,6 +1,6 @@ | |||
sudo: true | |||
language: java | |||
install: gradle clean | |||
install: ./gradlew clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is causing build failures in travis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My mistake, I didn't realize the .gitignore was excluding all jar files.
The reason of this change is that the current pipeline is wrong. The code specifies gradle version 2.3, but using gradle command it uses whichever version is installed into the travis container (4.X). So that produces a mismatch, and therefore possible building issues.
I excluded the gradle-wrapper.jar from the ignored list and now everything runs properly.
@jijisv I started with the gradle files as first step. The idea, if everybody agrees, could be to do a PR formatting properly all lines of code, where code shows full consistency. |
Hey @jijisv or @johnmcclean any chance to take a look to this? Thanks. |
…es. Add gradle wrapper.
…o misc/editorconfig
@jijisv or @johnmcclean I don't have privileges to merge the branch, so please, could you merge it? Thanks |
…orconfig # Conflicts: # build.gradle # micro-async-data-loader/build.gradle # micro-async-data-writer/build.gradle # micro-core/build.gradle # micro-guava/build.gradle # micro-jmx-metrics/build.gradle # micro-reactive/build.gradle # micro-s3/build.gradle
…eal with conflicts.
Code Changes: