Bar Charts not updating correctly on dataset change

[sbatson5]

Thanks for all the work on ember-cli-chart. I have an issue where we track interest payments over sets of years, with 2 data points:

However, when the loan is paid off faster than 10 years, the chart should update. Here is the default behavior:

To solve this, I edited chart-data-updater to check to see if the bars length matched our new dataset length:

    if (chart.datasets.length !== datasets.length) {
      return this.set('redraw', true);
    } else if (chart.datasets[0].bars.length !== datasets[0].data.length) {
      return this.set('redraw', true);
    }

Is there a better way to do this? Would it make sense to also confirm that the type is bar?

[aomran]

@sbatson5 the chart.datasets[0].bars won't work if it's not a bar chart as you might have guessed. chart.datasets[0].bars !== 'undefined' should do the trick.

It seems we keep running into edge cases with the automatic updating. I'm hoping Chartjs version 2 will fix all of these hacks once it's stable.

[sbatson5]

what if you passed the type to chart-data-updater?

    var redraw = ChartDataUpdater.create({
      data: data,
      chart: chart,
      type: type
    }).updateByType();

Then specified the type:

    if (chart.datasets.length !== datasets.length) {
      return this.set('redraw', true);
    } else if (this.get('type') === 'Bar' && chart.datasets[0].bars.length !== datasets[0].data.length) {
      return this.set('redraw', true);
    }

[sbatson5]

Misunderstood your first reply. Revised to:

    if (chart.datasets.length !== datasets.length) {
      return this.set('redraw', true);
    } else if (typeof chart.datasets[0].bars !== 'undefined') {
      if (chart.datasets[0].bars.length !== datasets[0].data.length) {
        return this.set('redraw', true);
      }
    }

[sbatson5]

@aomra015 Opened a PR with the above revision and unit test.
#30

[sbatson5]

@aomra015 Have you had a chance to look at the PR I opened regarding updating bar charts on dataset length changes? Let me know if it looks good or if you see any issues.

[aomran]

I'll try to find some time this weekend to review this. Thanks !

[aomran]

merged

[sbatson5]

👍 Thanks!