Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numba linterp function harms AO performance #11

Closed
andrewpaulreeves opened this issue Mar 16, 2015 · 1 comment
Closed

Numba linterp function harms AO performance #11

andrewpaulreeves opened this issue Mar 16, 2015 · 1 comment
Labels
numba

Comments

@andrewpaulreeves
Copy link
Collaborator

In the Numba branch, the aoSimLib.linterp2d gives an enormous computational performance boost vs scipy.interp2d. Unfortunately, it also seems to harm AO performance, giving a drop of ~10% strehl for a 4" off-axis, 8x8 WFS in some of the example config files.

Requires a better look at the algorithm to see where I've gone wrong with it.
@andrewpaulreeves
Copy link
Collaborator Author

Was due to an error in bilinear interpolation. Fixed now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
numba
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andrewpaulreeves