This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat: add mergeMargin() function #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #114 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 73 74 +1
Lines 891 898 +7
Branches 205 211 +6
=====================================
+ Hits 891 898 +7
Continue to review full report at Codecov.
|
williaster
approved these changes
Mar 6, 2019
| const { top = 0, left = 0, bottom = 0, right = 0 } = margin1; | ||
| const { top: top2 = 0, left: left2 = 0, bottom: bottom2 = 0, right: right2 = 0 } = margin2; | ||
|
|
||
| return mode === 'expand' |
There was a problem hiding this comment.
you could simplify this a bit
const func = mode === 'expand' ? Math.max : Math.min;
return {
bottom: func(bottom, bottom2),
...repeat
};
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃弳 Enhancements
mergeMargin()function for combining two margins.