Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: add dimension type #117

Merged
merged 1 commit into from
Mar 11, 2019
Merged

feat: add dimension type #117

merged 1 commit into from
Mar 11, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Mar 11, 2019

馃弳 Enhancements

Add Dimension type

@kristw kristw requested a review from a team as a code owner March 11, 2019 20:48
@codecov
Copy link

codecov bot commented Mar 11, 2019 •
edited
Loading

Codecov Report

Merging #117 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #117   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          74     74           
  Lines         898    898           
  Branches      211    211           
=====================================
  Hits          898    898
Impacted Files Coverage 螖
...es/superset-ui-dimension/src/computeMaxFontSize.ts 100% <酶> (酶) 猬嗭笍
...ages/superset-ui-dimension/src/getTextDimension.ts 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8c3f8b0...de9c589. Read the comment docs.

williaster
williaster approved these changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay TS

@kristw kristw merged commit e4a22ad into master Mar 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--dim branch March 11, 2019 20:58
kristw added a commit that referenced this pull request Apr 17, 2020
@kristw
feat: implement labelFlush behavior for continuous axes (#117)
a747ea4 
* feat: add labelFlush to definition

* feat: implement flushing
@xiezhongfu xiezhongfu mentioned this pull request May 17, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@williaster williaster williaster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kristw @williaster