Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: make translation module type check correctly #140

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Apr 26, 2019

馃悰 Bug Fix

  • type of singleton can be undefined before the first configure() or getInstance() call.

@kristw kristw requested a review from a team as a code owner April 26, 2019 05:56
@netlify
Copy link

netlify bot commented Apr 26, 2019

Deploy preview for superset-ui ready!

Built with commit 6b53dc8

https://deploy-preview-140--superset-ui.netlify.com

@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #140 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #140   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          77     77           
  Lines         988    988           
  Branches      238    238           
=====================================
  Hits          988    988
Impacted Files Coverage 螖
...superset-ui-translation/src/TranslatorSingleton.ts 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 0ef1436...6b53dc8. Read the comment docs.

@kristw kristw merged commit c05fe3a into master Apr 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--translate-type branch April 26, 2019 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants