Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat: add hooks field to ChartProps #158

Merged
merged 1 commit into from
May 16, 2019
Merged

feat: add hooks field to ChartProps #158

merged 1 commit into from
May 16, 2019

Conversation

kristw
Copy link
Contributor

@kristw kristw commented May 16, 2019

馃弳 Enhancements

  • Add hooks field to contains non-serializable configuration and optional overrides such as TooltipRenderer, LegendRenderer that cannot go into formData.

@kristw kristw requested a review from a team as a code owner May 16, 2019 18:32
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #158   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          81     81           
  Lines        1044   1047    +3     
  Branches      258    259    +1     
=====================================
+ Hits         1044   1047    +3
Impacted Files Coverage 螖
...ackages/superset-ui-chart/src/models/ChartProps.ts 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ecf59c6...93668ca. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #158   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          81     81           
  Lines        1044   1047    +3     
  Branches      258    259    +1     
=====================================
+ Hits         1044   1047    +3
Impacted Files Coverage 螖
...ackages/superset-ui-chart/src/models/ChartProps.ts 100% <100%> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ecf59c6...93668ca. Read the comment docs.

@kristw kristw merged commit 7b3ab5f into master May 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--hooks branch May 16, 2019 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant