This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat: add parseLength function to @superset-ui/dimension #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 88 89 +1
Lines 1102 1109 +7
Branches 264 267 +3
=====================================
+ Hits 1102 1109 +7
Continue to review full report at Codecov.
|
|
Deploy preview for superset-ui ready! Built with commit 5408178 |
khtruong
reviewed
Jun 12, 2019
| return HUNDRED_PERCENT; | ||
| } else if (typeof input === 'string' && input.length > 0 && input[input.length - 1] === '%') { | ||
| // eslint-disable-next-line no-magic-numbers | ||
| return { isDynamic: true, multiplier: parseFloat(input.substring(0, input.length - 1)) / 100 }; |
There was a problem hiding this comment.
you could do parseFloat(input). If the string starts with a number, parseFloat will just ignore the random characters. Comment applies below too.
There was a problem hiding this comment.
Oh cool. Didn't know that!
khtruong
approved these changes
Jun 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃弳 Enhancements
Add function
parseLengthto parse width or height'100%'=>{ isDynamic: true, multiplier: 1 }'50%'=>{ isDynamic: true, multiplier: 0.5 }100=>{ isDynamic: false, value: 100 }'100'=>{ isDynamic: false, value: 100 }100px=>{ isDynamic: false, value: 100 }