feat: add error boundary and responsiveness to SuperChart #175
Conversation
kristw
changed the title
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 90 94 +4
Lines 1123 1157 +34
Branches 268 276 +8
=====================================
+ Hits 1123 1157 +34
Continue to review full report at Codecov.
|
|
Deploy preview for superset-ui ready! Built with commit 5c49d27 |
kristw
changed the title
|
This PR is ready for review |
|
|
||
| export default class SuperChart extends React.PureComponent<SuperChartProps, {}> { | ||
| export default class SuperChart extends React.PureComponent<Props, {}> { |
There was a problem hiding this comment.
Kernel makes this a little less understandable/more complex IMO, Base or Core seems a little more approachable 馃
| }; | ||
|
|
||
| /** SuperChart Props for version 0.11 and below has chartProps */ | ||
| type ClassicProps = Omit<SuperChartKernelProps, 'chartProps'> & { |
There was a problem hiding this comment.
do we need to support both prop types? with a breaking version couldn't we just change to the new API?
or if you want to keep them around for a version, could we instead only support the new API in this component, and add a wrapper that just spreads chartProps to simplify this component?
* feat: update type for line chart series * fix: another place
馃彔 Internal
SuperChartclass toSuperChartCore.@vx/responsivetype declaration.馃弳 Enhancements
Create new class
SuperChartthat wrapsSuperChartCore.Create another new class
SuperChartShellto wrapSuperChartand provide backward-compatibility API. This can be removed in the upcoming breaking change.SuperChartShellis exported asSuperChartand provide 100% backward-compatibility.ErrorBoundary, which can be disabled if needed.widthheightasnumberor dynamic value such as100%.chartPropsfields to top-level.Before
This behavior is still supported, but less preferred.
Enhancement#1 Support plain object as
chartPropsThis format was used in many Storybooks, although it will show error once the story is converted to typescript. With this PR, the pattern is now legit.
Enhancement#2 Can list the fields as props to
SuperChartThe new preferred way, which should be more natural.
See the storybook preview. Can use knobs to adjust
widthandheight.This one shows error boundary.