[monorepo] add travis + codecov ✅ #2

williaster · 2018-09-07T19:55:25Z

This PR attempts to add travis to the build so it fails when prettier, linting, or testing fails.

@kristw @conglei @john-bodley @mistercrunch

john-bodley · 2018-09-07T19:58:47Z

package.json

@@ -27,6 +27,7 @@
  ],
  "license": "Apache-2.0",
  "devDependencies": {
+    "coveralls": "^3.0.2",


Can we use Codecov instead of Coveralls? This ensures consistency with incubator-superset and doesn’t require a token.

yes, I initially tried codecov and couldn't add it to this repo so tried coveralls ... still can't add it to the repo so I'll move back to coveralls 👍

So the after-script command fails,

$ ./node_modules/.bin/codecov /home/travis/.travis/job_stages: line 78: ./node_modules/.bin/codecov: No such file or directory

john-bodley · 2018-09-07T20:00:08Z

.travis.yml

+  fast_finish: true
+
+install:
+  - npm install && lerna bootstrap


I believe you can list each command seperately.

williaster · 2018-09-07T23:39:22Z

things are all getting executed correctly, trying to debug why coverage %s are being reported as unknown.

codecov · 2018-09-08T00:36:04Z

Codecov Report

❗ No coverage uploaded for pull request base (chris--core-package@b3ffc4e). Click here to learn what that means.
The diff coverage is n/a.

@@                  Coverage Diff                   @@
##             chris--core-package       #2   +/-   ##
======================================================
  Coverage                       ?   98.46%           
======================================================
  Files                          ?        7           
  Lines                          ?       65           
  Branches                       ?        0           
======================================================
  Hits                           ?       64           
  Misses                         ?        1           
  Partials                       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3ffc4e...00211cc. Read the comment docs.

williaster · 2018-09-08T00:37:48Z

It only took 16 commits but 🎉 (there was an issue with @data-ui/build-config and jest rootDir configuration)

john-bodley · 2018-09-08T00:54:41Z

.travis.yml

@@ -20,4 +21,4 @@ script:
  - 'cd ./packages/$PACKAGE && yarn install && yarn run lint && yarn run test'

 after_script:
-  - './node_modules/codecov/bin/codecov'
+  - 'codecov'


Nix the quotes.

@john-bodley for all scripts?

john-bodley · 2018-09-08T15:54:15Z

.travis.yml

+  - PACKAGE=superset-ui-core
+
+script:
+  - cd ./packages/$PACKAGE && yarn install && yarn run lint && yarn run test


You can split the script to br a series of commands,

script: - cd ./packages/$PACKAGE - yarn install - ...

that's prob nicer for debugging too 👍

john-bodley · 2018-09-08T18:40:59Z

.travis.yml

+language: node_js
+
+node_js:
+  - '10.7'


Nix the quotes here too.

williaster · 2018-09-10T01:54:29Z

gonna merge this into the wrong branch to get a cherry pickable hash for master. don't think I can change the branch I'm merging into now and the other is merged.

* [monorepo] initial attempt at travis * [monorepo] coveralls => codecov * [monorepo] don't lerna bootstrap? * [monorepo] ignore lock files, add lint:fix script * [core] add node-fetch dev dep * [monorepo] tweak codecov call * [monorepo] tweak codecov call take ii * [monorepo] codecov again * [core][deps] build-config@^0.0.11 * [core][jest] add <rootDir> to coveragePathIgnorePatterns paths * [core][jest] add collectCoverageFrom config * [core][jest] try adding rootDir to collectCoverageFrom glob * [core][deps] build-config@0.0.12 * [travis] yolo * [travis] this is the one * [travis] install global codecov * [travis] no quotes in yml * [travis] no quotes in yml part 2

* [build] fix typescript builds * [typescript] ensure types pass in build * [typescript][connection] declare modules in tests * [typescript][connection] fix ts errors in tests * [typescript][connection] test/types.ts => types/external.d.ts * [chart][typescript] add @types/react-loadable * [chart][components] convert to ts * [charts][tests][broken] convert to ts * [chart][typescript] re-write component generics * [chart][typescript] fix reactify generic, add react-dom types * [chart][typescript] more iteration * - Tweaking reactify types (using Readonly types). - Uncovered an issue in which ReactifyProps and Props can collide on id and className. - Move @types/react-loadable to dev dependency - Fixing a lint error * [chart][deps] add @types/fetch-mock * [client][typescript] add and export SupersetClientInterface * [chart][clients] fix ts * [charts][components] more ts iterations * [chart][client] assert FormData type * [chart][deps] try adding newest @types/react * [chart][components][ts] fix reactify prop TS * [chart] lint * [chart][ts] lint #2, move @types to deps not dev-deps * [chart][jest] fix tests * [chart][tests] up branch coverage * [chart][ts][test] null => undefined * [chart][tests] hundo * [chart][tests] update name * [chart][ts] ChartClient type fixes

…country-map (#2)

* feat: add plugin for Kepler * fix: add dep and update naming for consistency * fix: lint issues

john-bodley reviewed Sep 7, 2018

View reviewed changes

williaster changed the title ~~[monorepo] add travis ✅~~ [monorepo] add travis + codecov ✅ Sep 7, 2018

williaster added 4 commits September 7, 2018 14:49

[monorepo] initial attempt at travis

08a1758

[monorepo] coveralls => codecov

b238f45

[monorepo] don't lerna bootstrap?

9edbc36

[monorepo] ignore lock files, add lint:fix script

dcb8ac2

williaster force-pushed the chris--coverage branch from 6481dfb to dcb8ac2 Compare September 7, 2018 21:51

williaster added 4 commits September 7, 2018 14:57

[core] add node-fetch dev dep

5487466

[monorepo] tweak codecov call

0e569cc

[monorepo] tweak codecov call take ii

93e95e5

[monorepo] codecov again

6f6ee96

williaster added 8 commits September 7, 2018 16:54

[core][deps] build-config@^0.0.11

e893b55

[core][jest] add <rootDir> to coveragePathIgnorePatterns paths

dcb95db

[core][jest] add collectCoverageFrom config

2e71e12

[core][jest] try adding rootDir to collectCoverageFrom glob

d11698e

[core][deps] build-config@0.0.12

9cc8b7d

[travis] yolo

5774d47

[travis] this is the one

207f356

[travis] install global codecov

39c705f

john-bodley reviewed Sep 8, 2018

View reviewed changes

[travis] no quotes in yml

f1ff034

john-bodley reviewed Sep 8, 2018

View reviewed changes

.travis.yml Outdated

language: node_js

node_js:

- '10.7'

Copy link

Contributor

john-bodley Sep 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nix the quotes here too.

[travis] no quotes in yml part 2

00211cc

john-bodley approved these changes Sep 9, 2018

View reviewed changes

williaster merged commit 9a791f7 into chris--core-package Sep 10, 2018

williaster mentioned this pull request Sep 10, 2018

[monorepo] add travis + codecov ✅ #3

Merged

kristw added reviewable Ready for review and removed reviewable Ready for review labels Nov 13, 2018

williaster pushed a commit that referenced this pull request Dec 13, 2018

[chart][ts] lint #2, move @types to deps not dev-deps

4aabf67

williaster pushed a commit that referenced this pull request Dec 14, 2018

[chart][ts] lint #2, move @types to deps not dev-deps

5fbcb48

soboko mentioned this pull request Jan 8, 2019

Handle BigNumber conversions in JSON properly (without loss of precision) #71

Merged

kristw pushed a commit that referenced this pull request Apr 17, 2020

feat: add country map of bulgaria in superset-ui-legacy-plugin-chart-…

ba113c2

…country-map (#2)

xiezhongfu mentioned this pull request May 15, 2021

fix(plugin-chart-echarts): funnel chart improvements #1110

Merged

zhaoyongjie pushed a commit to zhaoyongjie/superset-ui that referenced this pull request Sep 23, 2021

feat: add plugin for Kepler (apache-superset#2)

5d62973

* feat: add plugin for Kepler * fix: add dep and update naming for consistency * fix: lint issues

zhaoyongjie pushed a commit to zhaoyongjie/superset-ui that referenced this pull request Sep 24, 2021

feat: add plugin for Kepler (apache-superset#2)

2377d26

* feat: add plugin for Kepler * fix: add dep and update naming for consistency * fix: lint issues

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[monorepo] add travis + codecov ✅ #2

[monorepo] add travis + codecov ✅ #2

williaster commented Sep 7, 2018

john-bodley Sep 7, 2018 •

edited

Loading

williaster Sep 7, 2018

john-bodley Sep 7, 2018

john-bodley Sep 7, 2018

williaster commented Sep 7, 2018

codecov bot commented Sep 8, 2018 •

edited

Loading

williaster commented Sep 8, 2018 •

edited

Loading

john-bodley Sep 8, 2018

williaster Sep 8, 2018

john-bodley Sep 8, 2018

williaster Sep 8, 2018

john-bodley Sep 8, 2018

williaster commented Sep 10, 2018

[monorepo] add travis + codecov ✅ #2

[monorepo] add travis + codecov ✅ #2

Conversation

williaster commented Sep 7, 2018

john-bodley Sep 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

williaster commented Sep 7, 2018

codecov bot commented Sep 8, 2018 • edited Loading

Codecov Report

williaster commented Sep 8, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

williaster commented Sep 10, 2018

john-bodley Sep 7, 2018 •

edited

Loading

codecov bot commented Sep 8, 2018 •

edited

Loading

williaster commented Sep 8, 2018 •

edited

Loading