This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix: d3-scale typings #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #246 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 142 142
Lines 1578 1578
Branches 409 409
=====================================
Hits 1578 1578Continue to review full report at Codecov.
|
|
Deploy preview for superset-ui ready! Built with commit 650cac2 |
kristw
added a commit
that referenced
this pull request
Apr 17, 2020
* feat: optimize table rendering * fix: memoize * fix: more opti * fix: bug * fix: render 0 * fix: return type * Update HTMLRenderer.tsx
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃彔 Internal
nullandundefinedas input to categorical scales. Tried to PR this into@types/d3-scaleand receive good discussion that it should not acceptnullundefined. The coercion tostringshould be explicit. Not really a breaking change because this package has not been released yet.