Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

fix: npm exclude template files from generator-superset #34

Merged
merged 1 commit into from
Nov 15, 2018

Conversation

kristw
Copy link
Contributor

@kristw kristw commented Nov 15, 2018

馃悰 Bug Fix
Fix: npm was ignoring the files in templates directory because it was reading files field from the package.json in templates directory

@kristw kristw requested a review from a team as a code owner November 15, 2018 04:20
@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #34 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #34   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          41     41           
  Lines         345    345           
=====================================
  Hits          345    345
Impacted Files Coverage 螖
...ges/generator-superset/generators/package/index.js 100% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update c46776a...9410cdb. Read the comment docs.

@kristw kristw added the reviewable Ready for review label Nov 15, 2018
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristw kristw merged commit ba834ef into master Nov 15, 2018
@delete-merged-branch delete-merged-branch bot deleted the kristw--fix-generator branch November 15, 2018 19:11
@kristw kristw removed reviewable Ready for review labels Nov 17, 2018
@kristw kristw added this to the v0.7.0 milestone Nov 17, 2018
@kristw kristw added #bug Something isn't working and removed reviewable Ready for review labels Dec 6, 2018
kristw pushed a commit that referenced this pull request Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
#bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants