This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix: make all filter operators uppercase #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/superset/superset-ui/ghwmfneot |
villebro
force-pushed
the
villebro/uppercase-operators
branch
from
2098ed4
to
bfddf06
Compare
Codecov Report
@@ Coverage Diff @@
## master #378 +/- ##
=======================================
Coverage 26.35% 26.35%
=======================================
Files 192 192
Lines 5256 5256
Branches 459 459
=======================================
Hits 1385 1385
Misses 3842 3842
Partials 29 29
Continue to review full report at Codecov.
|
ktmud
approved these changes
Apr 21, 2020
kristw
approved these changes
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Currently unary operators are uppercase, while binary and set operators are lowercase, which looks weird. As of PR 9556 Superset now expects all filter operators to be uppercase (it does work with lowercase, but this support might be removed at some point).