This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Use factory to create D3 number formatter in @superset-ui/number-format #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
changed the title
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=========================================
- Coverage 99.11% 99.1% -0.01%
=========================================
Files 48 48
Lines 450 449 -1
Branches 39 39
=========================================
- Hits 446 445 -1
Misses 2 2
Partials 2 2
Continue to review full report at Codecov.
|
xtinec
approved these changes
Nov 29, 2018
| }); | ||
| describe('if it is invalid d3 formatString', () => { | ||
| it('The format function displays error message', () => { | ||
| const formatter = createD3NumberFormatter({ formatString: 'i-am-groot' }); |
kristw
added
#enhancement
kristw
pushed a commit
that referenced
this pull request
Apr 17, 2020
…#42) Tap into the newly added `willUnmount` hook to clean up sticky tooltip that nvd3 adds to `body` directly. This removes such tooltips that were left behind in the explore view with the new query returns 'no data'.
zhaoyongjie
pushed a commit
to zhaoyongjie/superset-ui
that referenced
this pull request
Sep 23, 2021
zhaoyongjie
pushed a commit
to zhaoyongjie/superset-ui
that referenced
this pull request
Sep 24, 2021
stephenLYZ
referenced
this pull request
in stephenLYZ/superset-ui
Nov 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏠 Internal
D3NumberFormatteras subclass ofNumberFormatterwith different constructor, use a factory pattern to createNumberFormatwith the givend3format string. This seems like a better API sinceD3NumberFormatteris not taking advantage of the inheritance and also defining a subclass that has quite different constructor from parent can be confusing. The factory function fits better with this context.time-formatis also written in the factory style.