Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(plugin-chart-word-cloud): add control panel #454

Merged
merged 2 commits into from
May 8, 2020

Conversation

suddjian
Copy link
Member

@suddjian suddjian commented May 7, 2020

🏆 Enhancements

Word Cloud now has its own control panel.

I also picked up some automatic yarn.lock changes.

@suddjian suddjian requested a review from a team as a code owner May 7, 2020 19:50
@vercel
Copy link

vercel bot commented May 7, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/2qyjgz38t
✅ Preview: https://superset-ui-git-fork-suddjian-word-cloud-controls.superset.now.sh

@kristw kristw changed the title chore: add word cloud control panel feat(plugin-chart-word-cloud): add control panel May 7, 2020
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #454 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #454      +/-   ##
==========================================
+ Coverage   22.25%   22.36%   +0.11%     
==========================================
  Files         265      266       +1     
  Lines        6521     6549      +28     
  Branches      591      605      +14     
==========================================
+ Hits         1451     1465      +14     
- Misses       5033     5047      +14     
  Partials       37       37              
Impacted Files Coverage Δ
...lugins/plugin-chart-word-cloud/src/plugin/index.ts 33.33% <ø> (ø)
packages/superset-ui-translation/src/Translator.ts 100.00% <0.00%> (ø)
...ugins/preset-chart-xy/src/components/Line/Line.tsx 0.00% <0.00%> (ø)
...gins/preset-chart-xy/src/BoxPlot/transformProps.ts 0.00% <0.00%> (ø)
...ages/superset-ui-connection/src/callApi/callApi.ts 100.00% <0.00%> (ø)
...ins/legacy-preset-chart-nvd3/src/transformProps.js 0.00% <0.00%> (ø)
...s/legacy-plugin-chart-table/src/ReactDataTable.tsx 64.86% <0.00%> (ø)
...preset-chart-xy/src/components/BoxPlot/BoxPlot.tsx 0.00% <0.00%> (ø)
...eset-chart-xy/src/BoxPlot/legacy/transformProps.ts 0.00% <0.00%> (ø)
...rset-ui-chart/test/components/MockChartPlugins.tsx 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0483db6...af43b7d. Read the comment docs.

@rusackas rusackas merged commit 18375db into apache-superset:master May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants