Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(legacy-plugin-chart-chord): control panel #481

Merged
merged 1 commit into from
May 13, 2020

Conversation

suddjian
Copy link
Member

Complete control

@suddjian suddjian requested a review from a team as a code owner May 12, 2020 23:27
@vercel
Copy link

vercel bot commented May 12, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/68qeymqxb
✅ Preview: https://superset-ui-git-fork-suddjian-chord-controls.superset.now.sh

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #481 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #481   +/-   ##
=======================================
  Coverage   22.38%   22.38%           
=======================================
  Files         270      270           
  Lines        6562     6562           
  Branches      608      608           
=======================================
  Hits         1469     1469           
  Misses       5056     5056           
  Partials       37       37           
Impacted Files Coverage Δ
plugins/legacy-plugin-chart-chord/src/index.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b569c34...acbaa25. Read the comment docs.

@kristw kristw merged commit d82d948 into apache-superset:master May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants