This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat(query): remove redundant metric label truncation #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/7p6zzn8yt |
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
==========================================
- Coverage 22.75% 22.72% -0.03%
==========================================
Files 276 276
Lines 6672 6670 -2
Branches 645 644 -1
==========================================
- Hits 1518 1516 -2
Misses 5115 5115
Partials 39 39
Continue to review full report at Codecov.
|
kristw
approved these changes
May 15, 2020
kristw
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
When working on another PR I noticed this redundant metric label mutation logic. For some time now, the Superset backend has supported arbitrary column/metric names, despite restrictions in the database. Check apache/superset#5827 for more context.