Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(legacy-plugin-chart-event-flow): migrate package #514

Merged
merged 1 commit into from
May 21, 2020

Conversation

kristw
Copy link
Contributor

@kristw kristw commented May 20, 2020

🏆 Enhancements

Move legacy-plugin-chart-event-flow from sandbox so it will get published with the control panel.

cc @suddjian

@kristw kristw requested a review from a team as a code owner May 20, 2020 23:10
@vercel
Copy link

vercel bot commented May 20, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/3ykt9hc1j
✅ Preview: https://superset-ui-git-kristw-event-flow.superset.now.sh

@codecov
Copy link

codecov bot commented May 20, 2020

Codecov Report

Merging #514 into master will decrease coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #514      +/-   ##
==========================================
- Coverage   22.63%   22.52%   -0.12%     
==========================================
  Files         281      285       +4     
  Lines        6692     6725      +33     
  Branches      648      651       +3     
==========================================
  Hits         1515     1515              
- Misses       5138     5171      +33     
  Partials       39       39              
Impacted Files Coverage Δ
...s/legacy-plugin-chart-event-flow/src/EventFlow.jsx 0.00% <ø> (ø)
...egacy-plugin-chart-event-flow/src/controlPanel.jsx 0.00% <ø> (ø)
...lugins/legacy-plugin-chart-event-flow/src/index.js 0.00% <ø> (ø)
...gacy-plugin-chart-event-flow/src/transformProps.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf83908...76d07e5. Read the comment docs.

@kristw kristw requested review from rusackas and suddjian May 21, 2020 00:10
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kristw kristw merged commit 3589e31 into master May 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the kristw--event-flow branch May 21, 2020 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants