This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
fix(legacy-plugin-chart-table): parse numeric pageLength #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/bju3sdtoy |
|
|
|
Hmm. Not sure what was changed in that mass bump. |
ktmud
force-pushed
the
fix-table-page-length
branch
from
6e6a56c
to
fcadf45
Compare
Codecov Report
@@ Coverage Diff @@
## master #522 +/- ##
==========================================
+ Coverage 22.51% 22.52% +0.01%
==========================================
Files 285 285
Lines 6729 6729
Branches 651 651
==========================================
+ Hits 1515 1516 +1
Misses 5175 5175
+ Partials 39 38 -1
Continue to review full report at Codecov.
|
kristw
approved these changes
May 21, 2020
ktmud
added a commit
to ktmud/superset
that referenced
this pull request
May 22, 2020
Bump @superset-ui/legacy-preset-chart-table to fix disabled page length support. See apache-superset/superset-ui#522
6 tasks
john-bodley
pushed a commit
to apache/superset
that referenced
this pull request
May 22, 2020
Bump @superset-ui/legacy-preset-chart-table to fix disabled page length support. See apache-superset/superset-ui#522
john-bodley
pushed a commit
to airbnb/superset-fork
that referenced
this pull request
May 22, 2020
Bump @superset-ui/legacy-preset-chart-table to fix disabled page length support. See apache-superset/superset-ui#522 (cherry picked from commit 6d4e236)
pkdotson
pushed a commit
to preset-io/superset
that referenced
this pull request
May 26, 2020
Bump @superset-ui/legacy-preset-chart-table to fix disabled page length support. See apache-superset/superset-ui#522
auxten
pushed a commit
to auxten/incubator-superset
that referenced
this pull request
Nov 20, 2020
Bump @superset-ui/legacy-preset-chart-table to fix disabled page length support. See apache-superset/superset-ui#522
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Pagination for table chart had stopped working because
pageLengthparam somehow is not string any more.This fix makes
transformPropshandle both numeric and string values and added unit tests.