This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
Allow metrics arrays in form data #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics can take shape of an array of metrics in form data for a given metrics key. For example, `{ metrics: ['sum__num'] }`. This PR changes Metrics class to handle the array case.
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 65 65
Lines 625 629 +4
Branches 68 70 +2
=====================================
+ Hits 625 629 +4
Continue to review full report at Codecov.
|
kristw
approved these changes
Dec 12, 2018
delete-merged-branch
bot
deleted the
xtinec--support-metric-arrays-form-data
branch
kristw
added a commit
that referenced
this pull request
Apr 17, 2020
* feat: update line chart thumbnail * fix: lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃彔 Internal
Metrics can take shape of an array of metrics in form data for a given metrics key. For example,
{ metrics: ['sum__num'] }. This PR changes Metrics class to handle the array case.