This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
[chart plugin]TableVis Plugin #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
reviewed
Dec 14, 2018
| import $ from 'jquery'; | ||
| import PropTypes from 'prop-types'; | ||
| import dt from 'datatables.net-bs'; | ||
| import 'datatables.net-bs/css/dataTables.bootstrap.css'; |
There was a problem hiding this comment.
we may not be able to import this type of file in babel.
if we refactor datatables and still need to import css, we could instead copy it in the lib output, and have incubator superset import (since it has proper css loader support)
kristw
added a commit
that referenced
this pull request
Apr 17, 2020
* fix: fallback to default margin when margin is partially set * feat: can disable axis title * feat: adjust margin according to axis title visibility * feat: include margin in formData * feat: add buildQuery * fix: address kyle comments * fix: remove string false
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃挃 Breaking Changes
馃弳 Enhancements
This is to bring tablevis as a plugin.
馃摐 Documentation
馃悰 Bug Fix
馃彔 Internal