You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
src/main/resources/org/apache/accumulo/access/specification/AccessExpression.abnf exists for the sole purpose of validating that the ABNF in SPECIFICATION.md is valid ABNF. The contents of AccessExpression.abnf are a copy of the ABNF in SPECIFICATION.md. AccessExpressionTest.testSpecificationDocumentation and AccessExpression.abnf could be deleted and the method used in AccessExpressionTest.testSpecificationDocumentation to get the ABNF from SPECIFICATION.md could be used in SpecificationTest.
The text was updated successfully, but these errors were encountered:
I don't want to do that, because I think it's useful as a jar resource so it can be used as a dependency by other projects who might want to pull it in as the canonical definition.
ok, so that's why you added the test for equality between SPECIFICATION.md and AccessExpression.abnf. I'm fine with that, I just thought we wanted to remove the duplication.
ok, so that's why you added the test for equality between SPECIFICATION.md and AccessExpression.abnf. I'm fine with that, I just thought we wanted to remove the duplication.
Yes, exactly. Deduplication was my preference, but I decided to punt on that for now. We could still deduplicate by removing it from SPECIFICATION.md... but I'm not sure how much affinity people had for having it there, rather than just having a link there to the abnf file.
src/main/resources/org/apache/accumulo/access/specification/AccessExpression.abnf
exists for the sole purpose of validating that the ABNF inSPECIFICATION.md
is valid ABNF. The contents ofAccessExpression.abnf
are a copy of the ABNF inSPECIFICATION.md
.AccessExpressionTest.testSpecificationDocumentation
andAccessExpression.abnf
could be deleted and the method used inAccessExpressionTest.testSpecificationDocumentation
to get the ABNF fromSPECIFICATION.md
could be used inSpecificationTest
.The text was updated successfully, but these errors were encountered: