Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement]: Display more details in the page of Optimizing->Optimizers #2698

Closed
3 tasks done
Tracked by #2176
tcodehuber opened this issue Apr 2, 2024 · 14 comments · Fixed by #2699
Closed
3 tasks done
Tracked by #2176

[Improvement]: Display more details in the page of Optimizing->Optimizers #2698

tcodehuber opened this issue Apr 2, 2024 · 14 comments · Fixed by #2699

Comments

@tcodehuber
Copy link
Contributor

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Now there are only a few of columns displaying in the Tab of Optimizing->Optimizers. IMO, we can show more columns(startTime, touchTime, jobJd etc.) to distinguish the optimizers.
image

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct

@XBaith
Copy link
Contributor

XBaith commented Apr 2, 2024

Hi @tcodehuber , Consider displaying the optimizer token id on the page so that we can identifier the different optimizer

@tcodehuber
Copy link
Contributor Author

@XBaith JobId(Optimizer Id) usually contains resourceid. Can it be considered as identifier for different optimizers?

image

@XBaith
Copy link
Contributor

XBaith commented Apr 2, 2024

@XBaith JobId(Optimizer Id) usually contains resourceid. Can it be considered as identifier for different optimizers?

In some scenarios, the resouceid is empty or just a subindex, which I don't think is clear enough

@tcodehuber
Copy link
Contributor Author

image

@baiyangtx
Copy link
Contributor

I think it is useful that OptimizerId can distinguish between different optimizer instances, but for Token and Touch Time, it should be used more often to locate the problem, does this need to be displayed on the frontend?

Also, when there is an optimizerId to distinguish between different optimizer instances, it should be possible to cancel the order column, which has no practical meaning.

@tcodehuber
Copy link
Contributor Author

I think it is useful that OptimizerId can distinguish between different optimizer instances, but for Token and Touch Time, it should be used more often to locate the problem, does this need to be displayed on the frontend?

Also, when there is an optimizerId to distinguish between different optimizer instances, it should be possible to cancel the order column, which has no practical meaning.

Yes, i agree with discarding the order column. Furthermore, touchTime can be used as the active state for users.

@tcodehuber
Copy link
Contributor Author

@baiyangtx @XBaith Can we discuss whether displaying the Token column in the frontend?

@baiyangtx
Copy link
Contributor

Can we discuss whether displaying the Token column in the frontend?

Is it really necessary to display the token on the frontend, and in what scenarios do you need to know this value? @XBaith

Furthermore, touchTime can be used as the active state for users.

If the optimizer is not active, it will disappear from frontend.

@zhoujinsong
Copy link
Contributor

@tcodehuber @baiyangtx @XBaith
Have we reached a consensus on what content needs to be added to the page?

@tcodehuber
Copy link
Contributor Author

In my opinion, we can remove token from the frontend.

@XBaith
Copy link
Contributor

XBaith commented Apr 15, 2024

If the optimizer is not active, it will disappear from frontend.

Disply the token id can help us to identifier status of optimzier. It would be better if we make it more clear when the optimizer is expired via change the status in the front site. WDYT @baiyangtx ?

@baiyangtx
Copy link
Contributor

Disply the token id can help us to identifier status of optimzier. It would be better if we make it more clear when the optimizer is expired via change the status in the front site.

If you want to see a disconnected optimizer on the page, it's a better idea to display it with status.
I think the token is too low-level information to be displayed on the list page, maybe we can add a detail page, or hover to display some details. WDYT @zhoujinsong @XBaith

@XBaith
Copy link
Contributor

XBaith commented Apr 16, 2024

If you want to see a disconnected optimizer on the page, it's a better idea to display it with status.

+1. Currently, AMS optimizer only show the "running" status in the front page, it's a good way to expose more detail for optimizer.

@tcodehuber
Copy link
Contributor Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants