Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement]: Fix file upload when use derby as storage #622

Closed
3 tasks done
Aireed opened this issue Nov 16, 2022 · 0 comments · Fixed by #623
Closed
3 tasks done

[Improvement]: Fix file upload when use derby as storage #622

Aireed opened this issue Nov 16, 2022 · 0 comments · Fixed by #623
Assignees
@Aireed
Labels
type:improvement
Milestone
Release 0.4.0

Comments

@Aireed
Copy link
Contributor

Aireed commented Nov 16, 2022

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

  1. we should query the file after we add it , then we can get the record id because derby doesn't support useGeneratedKeys options
  2. remove catalog config from conf.yaml for it won't be used.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Subtasks

No response

Code of Conduct
@Aireed Aireed self-assigned this Nov 16, 2022
@Aireed Aireed added this to the Release 0.4.0 milestone Nov 16, 2022
@Aireed Aireed mentioned this issue Nov 16, 2022
Merged
3 tasks
@YesOrNo828 YesOrNo828 changed the title [Improvement]: fix file upload when use derby as storage [Improvement]: Fix file upload when use derby as storage Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aireed Aireed

Labels
type:improvement
Projects
None yet
Milestone
Release 0.4.0
Development

Successfully merging a pull request may close this issue.

[ARCTIC-622][Improvement]: fix file upload when use derby as storage
1 participant
@Aireed