[master] Changes for BZ-19516 #51
Conversation
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
an alternative would be to only wrap the stream inside of Thank you for dusting of really old issues. |
…, in certain cases
jaikiran
force-pushed
the
bz-19516-master
branch
from
759a9c1
to
17f06a9
Compare
|
Refer to this link for build results (access rights to CI server needed): |
@bodewig, I actually liked your idea. So I did an additional change in this commit (PR has been updated) to wrap the incoming stream into a stream that supports marking, if the incoming one doesn't. That way, it takes into account input streams that this Please take a look at the updated PR and let me know what you think. |
|
Refer to this link for build results (access rights to CI server needed): |
|
Looks good to me. |
|
Thanks for reviewing. Merged to master branch. Will backport it to 1.9.x too. |
As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses
java.io.BufferedInputStreamwhich can take an underlyingInputStreamand providemarksupport on the input stream. This should prevent loading a large amount of data into memory, in certain cases, in theZiptask.If this PR is approved, I'll then backport this pretty straightforward change to 1.9.x branch too.