Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnlineDebug throws error when sending request #1077

Closed
juzhiyuan opened this issue Dec 19, 2020 · 8 comments
Closed

OnlineDebug throws error when sending request #1077

juzhiyuan opened this issue Dec 19, 2020 · 8 comments
Assignees
Labels
backend documentation Improvements or additions to documentation enhancement New feature or request

Comments

@juzhiyuan
Copy link
Member

juzhiyuan commented Dec 19, 2020

Bug report

Describe the bug

图片

How to Reproduce

  1. Visit http://139.217.190.60/routes/list
  2. Go to Route list;
  3. Click on Online Debug;
  4. Input path "/hello";
  5. Click Send Request then error shown;
@juzhiyuan juzhiyuan added bug Something isn't working checking labels Dec 19, 2020
@juzhiyuan
Copy link
Member Author

Please take a look when you have time :)

cc @liuxiran

@juzhiyuan
Copy link
Member Author

图片

@liuxiran
Copy link
Contributor

liuxiran commented Dec 19, 2020

need to fill in the full URL of the request in the url input, e.g: http://ip:port/hello @juzhiyuan

Perhaps a simple FAQ can help users quickly know how to use this feature, let me add it. ^_^

@liuxiran liuxiran added documentation Improvements or additions to documentation bug Something isn't working and removed bug Something isn't working checking labels Dec 20, 2020
@juzhiyuan
Copy link
Member Author

oh I know what happened, the error says the protocol for that URL is missing 😂

@liuxiran liuxiran added the enhancement New feature or request label Dec 20, 2020
@liuxiran
Copy link
Contributor

oh I know what happened, the error says the protocol for that URL is missing 😂

yes you are right~! perhaps I need to do another enhancement

  • a clearer information about the error is needed here
  • fe add a input validation to reject not validate url

@juzhiyuan juzhiyuan added backend and removed bug Something isn't working labels Dec 20, 2020
@imjoey
Copy link
Member

imjoey commented Dec 30, 2020

Hi @juzhiyuan @liuxiran , since #1091 and #1092 had been merged, so shall we close this issue?

@liuxiran
Copy link
Contributor

Hi @juzhiyuan @liuxiran , since #1091 and #1092 had been merged, so shall we close this issue?

Thanks for your reminder @imjoey , another pr for update the debug api error msg is on the way, I will finish it ASAP

@liuxiran
Copy link
Contributor

As all prs has been merged, close this issue, feel free to reopen it when you need, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants