Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release files are different than the ones in the OCI helm registry. #732

Open
koshrf opened this issue Mar 12, 2024 · 0 comments
Open

Release files are different than the ones in the OCI helm registry. #732

koshrf opened this issue Mar 12, 2024 · 0 comments

Comments

@koshrf
Copy link

koshrf commented Mar 12, 2024

The file:

templates/service-gateway.yaml is different from the one in the release files downloaded from github.

For example externalTrafficPolicy doesn't work as intended when not using LoadBalancer/NodePort and it gives an error:

Error: INSTALLATION FAILED: 1 error occurred: * Service "apisix-gateway" is invalid: spec.externalTrafficPolicy: Invalid value: "Local": may only be set when type is 'NodePort' or 'LoadBalancer'

Because the 2 template files are different, in this case this part:

31,37c30,34 
<-- GitHub Release version -->
<   type: {{ .Values.gateway.type }}
<   {{- if or (eq .Values.gateway.type "LoadBalancer") (eq .Values.gateway.type "NodePort") }}
<   externalTrafficPolicy: {{ .Values.gateway.externalTrafficPolicy }}
<   {{- end }}
<   {{- if eq .Values.gateway.type "LoadBalancer" }}
<   {{- if .Values.gateway.loadBalancerIP }}
<   loadBalancerIP: {{ .Values.gateway.loadBalancerIP }}
---
<-- helm repo-->
>   type: {{ .Values.service.type }}
>   externalTrafficPolicy: {{ .Values.service.externalTrafficPolicy }}
>   {{- if eq .Values.service.type "LoadBalancer" }}
>   {{- if .Values.service.loadBalancerIP }}
>   loadBalancerIP: {{ .Values.service.loadBalancerIP }}
39c36

I haven't checked the other files but it seems the OCI Registry https://apache.github.io/apisix-helm-chart have different version of files regardless of the version it uses. Making it harder to use it and the need to download the release every single time instead of using the OCI Registry, something is wrong when creating the new versions for helm registry.

how to reproduce?
helm repo add apisix https://apache.github.io/apisix-helm-chart
helm repo update
helm pull apisix/apisix

Download the github release (any version that is on par with the registry)

Compare the files, they are different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant