Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: missing pass_host from ApisixUpstream CRD #1661

Closed
ohayak opened this issue Feb 10, 2023 · 7 comments
Closed

feat: missing pass_host from ApisixUpstream CRD #1661

ohayak opened this issue Feb 10, 2023 · 7 comments
Assignees
Labels
area/controller discuss good first issue Good for newcomers help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@ohayak
Copy link

ohayak commented Feb 10, 2023

Description

Hello
According to Upstream api docs https://apisix.apache.org/docs/apisix/2.15/admin-api/#request-body-parameters-3 we can edit the pass_host parameter, unfortunately this parameter is not defined in the CRD, is there any particular reason to not include it ?

Regards,

@tao12345666333
Copy link
Member

Thanks for your suggestion, just because we haven't implemented it yet.

I have not received related feature requests or use cases before.

Can you describe your scenario? Or just want to align the functionality?

@oyiadin
Copy link

oyiadin commented Mar 19, 2023

I need it too. Some of our upstreams need to recognize which "virtual host" is hitted by reading requests' hosts.

@Aaron199
Copy link

I need this functionality where, when going through an HTTPS proxy to retrieve data from other services such as OSS or OBS, it is not possible to retrieve the data without setting the host header.

@tao12345666333 tao12345666333 added good first issue Good for newcomers help wanted Extra attention is needed area/controller triage/accepted Indicates an issue or PR is ready to be actively worked on. labels May 25, 2023
@tao12345666333
Copy link
Member

Since we are currently focusing on the v1.7 release, there is no bandwidth to handle this requirement. Welcome to submit PR

@adam-huganir
Copy link

This feature would also help with the use case of when apisix is the external gateway (as it is in our case) but has to go through another internal gateway, for instance with Knative services where it needs the internal hostname to be directed to the right endpoints.

We have a workaround by setting them in the admin api, but i wanted to add a comment with another use case for when someone does have the bandwidth to take a stab at it. The behavior we would want to recreate here is to have an upstream crd fields to replicate this patch request in the admin api: '{"pass_host":"rewrite", "upstream_host":"<internal hostname here>"}'

@ikatlinsky
Copy link
Contributor

@tao12345666333 please, assign issue to me

@tao12345666333
Copy link
Member

#1889 has been merged, I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller discuss good first issue Good for newcomers help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Development

No branches or pull requests

6 participants