Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: check if the controller is restarted #1792

Open
AlinsRan opened this issue Apr 14, 2023 · 3 comments
Open

e2e: check if the controller is restarted #1792

AlinsRan opened this issue Apr 14, 2023 · 3 comments
Assignees
Labels
CI good first issue Good for newcomers help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@AlinsRan
Copy link
Contributor

AlinsRan commented Apr 14, 2023

todo

At the end of each e2e use case, detect if the controller has restarted.

background

To avoid incorrect coding causing the controller to crash and restart and make the test cases pass, we should detect and report it when cleaning up the cases.

related codes

Can be detected in the afterEach https://github.com/apache/apisix-ingress-controller/blob/master/test/e2e/scaffold/scaffold.go#L503.

@tao12345666333 tao12345666333 added good first issue Good for newcomers help wanted Extra attention is needed CI triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Apr 17, 2023
@ps-19
Copy link
Contributor

ps-19 commented Apr 18, 2023

I have a solution for this issue, but I am struggling with the testing part.

@tao12345666333
Copy link
Member

Very glad that you are interested in this, I have already assigned this issue to you.

FYI: https://github.com/apache/apisix-ingress-controller/tree/master/test/e2e

@tao12345666333
Copy link
Member

You can submit your changes through PR instead of pasting the code directly into the issue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI good first issue Good for newcomers help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants