Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add description parameter to ApisixConsumer #2223

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Add description parameter to ApisixConsumer #2223

wants to merge 2 commits into from

Conversation

jorgenll
Copy link

Type of change:

  • New feature provided

What this PR does / why we need it:

Add support for define the AsipixConsumer description on the CRD and propagate this information to the Consumer synchronized on APISIX.
I need to define the description of the consumer but the CRD don't support it. I've try to use a label as alternative but the Kubernetes spec don't allow whitespaces on labels.

fixes #2222

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@jorgenll
Copy link
Author

jorgenll commented Apr 25, 2024 •
edited

I've fix the e2e tests (I forgot the name conversion process...) and the lint problems.

I also review in my local environment the unit test and run successfully, but in the workflow the file cmd/ingress/ingress_test.go, test TestRotateLog, fails with connection refuse errors. Anyone can help my with this error?

Finally, I've a doubt: the release 1.8.1 was released on April 15th, but several files still use the 1.8.0 version (the Makefile for example) and the master branch diverge from this release (compare). I need to perform any change in my PR? Thanks!

@jorgenll
Copy link
Author

Hi! @pottekkat, could you execute again the workflow?
@Revolyssup, could you help me clarify the error with the unit-test?
Thanks all!!

@pottekkat
Copy link
Contributor

Trigged a rerun.

@jorgenll
Copy link
Author

Great, the workflow works fine and all is green. Thanks!!

@jorgenll
Copy link
Author

Hi @pottekkat, how should review the PR?

@pottekkat pottekkat requested a review from Revolyssup May 16, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Revolyssup Revolyssup Awaiting requested review from Revolyssup

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: As a user, I want to add support for consumer description
2 participants
@jorgenll @pottekkat