Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Missing "client/skip_mtls_uri_regex" in CRD ApisixTls in the schema (version 2) #2229

Open
rlaflamme opened this issue May 6, 2024 · 0 comments

Comments

@rlaflamme
Copy link

rlaflamme commented May 6, 2024

Current Behavior

We are using the version 1.8.0 that come from the helm chart 0.14.0. But the feature is not there too in the latest release 1.8.2

From the branch 1.8.0, The feature is not present in the schema (file conf/apisix-schema.json).
here

                "client": {
                    "required": [
                        "ca"
                    ],
                    "type": "object",
                    "properties": {
                        "ca": {
                            "minLength": 128,
                            "maxLength": 65536,
                            "type": "string"
                        },
                        "depth": {
                            "minimum": 0,
                            "default": 1,
                            "type": "integer"
                        }
                    }
                },
                "create_time": {
                    "type": "integer"
                },
...

However it is there in the samples (samples/deploy/crd/v1/ApisixTls.yaml)

here

      schema:
        openAPIV3Schema:
          description: ApisixTls defines SSL resource in APISIX.
          type: object
          properties:
            apiVersion:
              description: 'APIVersion defines the versioned schema of this representation
                of an object. Servers should convert recognized schemas to the latest
                internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#resources'
              type: string
            kind:
              description: 'Kind is a string value representing the REST resource
                this object represents. Servers may infer this from the endpoint the
                client submits requests to. Cannot be updated. In CamelCase. More
                info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#types-kinds'
              type: string
            metadata:
              type: object
            spec:
              description: ApisixTlsSpec is the specification of ApisixSSL.
              type: object
              required:
                - hosts
                - secret
              properties:
                ingressClassName:
                  type: string
                client:
                  description: ApisixMutualTlsClientConfig describes the mutual TLS
                    CA and verify depth
                  type: object
                  properties:
                    caSecret:
                      description: ApisixSecret describes the Kubernetes Secret name
                        and namespace.
                      type: object
                      required:
                        - name
                        - namespace
                      properties:
                        name:
                          type: string
                          minLength: 1
                        namespace:
                          type: string
                          minLength: 1
                    depth:
                      type: integer
                    skip_mtls_uri_regex:
                      type: array
                      items:
                        type: string
...

Expected Behavior

I was expecting to be present in the Schema.
Latest release (1.8.2) don't show it either

Error Logs

No response

Steps to Reproduce

  • deploy helm release 0.14.0 (ingress-controller 1.8.0)

Environment

artifact.io

@rlaflamme rlaflamme changed the title bug: Missing "client/skip_mtls_uri_regex" in CRD ApisixTls in the the schema (version 2) bug: Missing "client/skip_mtls_uri_regex" in CRD ApisixTls in the schema (version 2) May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant