Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The APISIX series Resources should be maintained in a separate repository #58

Closed
tokers opened this issue Dec 7, 2020 · 2 comments
Closed
Milestone

Comments

@tokers
Copy link
Contributor

tokers commented Dec 7, 2020

So far both apisix-ingress-controller and apisix-dashboard maintain their own definitions for each APISIX resource, like Route, Upstream, Consumers and so on.

I propose to keep the definitions for those resources in a separate repository, and versioning them according to the release of data plane.

Protobuf 3 is a good choice to definition them.

@gxthrj
Copy link
Contributor

gxthrj commented Dec 7, 2020

Agree

We can ref to https://github.com/kubernetes/code-generator/cmd/go-to-protobuf

the submodule apisix-types in apisix-ingress-controller also use the code-generator.

@gxthrj gxthrj added this to the 0.1.1 milestone Dec 7, 2020
@gxthrj gxthrj modified the milestones: 0.2.0, 0.3.0 Jan 4, 2021
@tokers
Copy link
Contributor Author

tokers commented Jan 20, 2021

No plan to support it yet.

@tokers tokers closed this as completed Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants