Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: As a user, I want to unify the keyring and key_encrypt_salt fields #10484

Closed
monkeyDluffy6017 opened this issue Nov 13, 2023 · 6 comments · Fixed by #10771
Closed

feat: As a user, I want to unify the keyring and key_encrypt_salt fields #10484

monkeyDluffy6017 opened this issue Nov 13, 2023 · 6 comments · Fixed by #10771
Assignees
Labels

Comments

@monkeyDluffy6017
Copy link
Contributor

Description

As we can see, the keyring and the key_encrypt_salt are used in the same way and with the same meaning, so i suggest that if we could unify the keyring and key_encrypt_salt fields?

@luoluoyuyu
Copy link
Contributor

I want to try it, please assign this issue to me

@luoluoyuyu
Copy link
Contributor

hi @monkeyDluffy6017
I want to use key_encrypt_salt to configure encryption of ssl and plugin data, do we need to consider compatibility issues if the current user has configured key_encrypt_salt and keycring respectively and has done a version upgrade?

@monkeyDluffy6017
Copy link
Contributor Author

  1. Why not use keyring ?
  2. no need to consider the compatbility, name your pr start with change:

@luoluoyuyu
Copy link
Contributor

  1. Why not use keyring ?
  2. no need to consider the compatbility, name your pr start with change:

@monkeyDluffy6017 ,thanks for the suggestion, I found that there is more code to use keyring than key_encrypt_salt, using key_encrypt_salt the amount of code would be smaller.

@monkeyDluffy6017
Copy link
Contributor Author

key_encrypt_salt is under the item ssl and not generic, keyring is better, and no need to consider the amount of code

@RitterHou
Copy link
Contributor

I am trying to fix this issue, can you assign it to me? @monkeyDluffy6017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants